Hi Olof, Sorry my misunderstanding.
2016-01-05 8:15 GMT+09:00 Masahiro Yamada <[email protected]>: > Hi Paul, Olof, > > 2016-01-05 4:22 GMT+09:00 Paul Gortmaker <[email protected]>: >> The Kconfig currently controlling compilation of this code is: >> >> drivers/bus/Kconfig:config UNIPHIER_SYSTEM_BUS >> drivers/bus/Kconfig: bool "UniPhier System Bus driver" >> >> ...meaning that it currently is not being built as a module by anyone. >> >> Lets remove the modular code that is essentially orphaned, so that >> when reading the driver there is no doubt it is builtin-only. >> >> Since module_platform_driver() uses the same init level priority as >> builtin_platform_driver() the init ordering remains unchanged with >> this commit. >> >> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. >> >> We also delete the MODULE_LICENSE tag etc. since all that information >> is already contained at the top of the file in the comments. >> >> Cc: Masahiro Yamada <[email protected]> >> Cc: Rob Herring <[email protected]> >> Cc: Arnd Bergmann <[email protected]> >> Cc: Olof Johansson <[email protected]> >> Cc: [email protected] >> Signed-off-by: Paul Gortmaker <[email protected]> > > > This driver can be modular. > > I wrote "tristate" in my original patch. > > See this one: > https://patchwork.kernel.org/patch/7805091/ > > > > But when I look at linux-next, it is "bool". > > > > Now, I realized what happened. > > Olof Johansson only said "Thanks, applied to next/drivers." > But, he silently modified my patch, > changing "tristate" into "bool". > > > Olof, > > Why did you do that? > > > I want this driver tristate. My bad - Olof had applied it as it is. It was changed from "tristate" to "bool" by commit 326ea45aa827da6686c78b5907f9839f91ef5782 Author: Arnd Bergmann <[email protected]> Date: Mon Dec 28 11:05:18 2015 +0100 bus: uniphier: allow only built-in driver I did not notice this. -- Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
