On Tue, Jan 05, 2016 at 12:03:43PM +0900, Namhyung Kim wrote: > When the 'trace_fields' sort key is used explicitly for non-tracepoint > events, it'll get segfault since it assumed evsel->tp_format was set. > Skip those events in add_all_dynamic_fields().
Acked-by: Jiri Olsa <[email protected]> thanks, jirka > > Signed-off-by: Namhyung Kim <[email protected]> > --- > tools/perf/util/sort.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c > index e558e87cafaf..59c4c8586d79 100644 > --- a/tools/perf/util/sort.c > +++ b/tools/perf/util/sort.c > @@ -1955,6 +1955,9 @@ static int add_all_dynamic_fields(struct perf_evlist > *evlist, bool raw_trace) > struct perf_evsel *evsel; > > evlist__for_each(evlist, evsel) { > + if (evsel->attr.type != PERF_TYPE_TRACEPOINT) > + continue; > + > ret = add_evsel_fields(evsel, raw_trace); > if (ret < 0) > return ret; > -- > 2.6.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
