On 2016/1/6 9:01, Steven Rostedt wrote: > On Fri, 25 Dec 2015 15:03:13 +0800 > "Qiu, PeiyangX" <[email protected]> wrote: > >> From: Qiu Peiyang <[email protected]> >> >> complete_formation might fail. kernel need clean up >> ftrace records of the module. >> >> The patch fixes it by tuning the operation sequence in >> complete_formation. After complete_formation checks >> verify_export_symbols, call ftrace_module_init to init >> ftrace records. >> >> Signed-off-by: Qiu Peiyang <[email protected]> >> Signed-off-by: Zhang Yanmin <[email protected]> >> --- >> kernel/module.c | 9 +++++---- >> 1 file changed, 5 insertions(+), 4 deletions(-) >> >> diff --git a/kernel/module.c b/kernel/module.c >> index 8f051a1..0a67c4e 100644 >> --- a/kernel/module.c >> +++ b/kernel/module.c >> @@ -3373,6 +3373,11 @@ static int complete_formation(struct module *mod, >> struct load_info *info) >> /* This relies on module_mutex for list integrity. */ >> module_bug_finalize(info->hdr, info->sechdrs, mod); >> >> + mutex_unlock(&module_mutex); >> + > First of all, this is buggy. You can't just move the locking of > module_mutex. That is needed to modify mod->state. > > Second of all, you are solving this wrong. I guess we should add > ftrace_module_init_fail() function to cover the cases where the module > can fail before calling do_init_module(), as if that happens it does > not call the module going notifiers.
It's a good idea although ftrace_module_init_fail might be complicated. Thanks, Yanmin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
