It is better to use dev_*() log functions instead of pr_*() to print information about the device in the kernel log in a standardized way.
This also allows to remove the local pr_fmt() defined macro. Suggested-by: Krzysztof Kozlowski <[email protected]> Signed-off-by: Javier Martinez Canillas <[email protected]> Acked-by: Laxman Dewangan <[email protected]> --- Changes in v3: - Add Laxman Dewangan's Acked-by tag to patch #7. Changes in v2: None drivers/rtc/rtc-max77686.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c index 09fc73016d3a..da47b1d85793 100644 --- a/drivers/rtc/rtc-max77686.c +++ b/drivers/rtc/rtc-max77686.c @@ -12,8 +12,6 @@ * */ -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt - #include <linux/slab.h> #include <linux/rtc.h> #include <linux/delay.h> @@ -245,8 +243,9 @@ static int max77686_rtc_tm_to_data(struct rtc_time *tm, u8 *data, data[RTC_YEAR] = tm->tm_year > 100 ? (tm->tm_year - 100) : 0; if (tm->tm_year < 100) { - pr_warn("RTC can't handle year %d. Assume it's 2000.\n", - 1900 + tm->tm_year); + dev_warn(info->dev, + "RTC can't handle year %d. Assume it's 2000\n", + 1900 + tm->tm_year); return -EINVAL; } } else { -- 2.5.0
