> The function is always returning zero even in case of failures since > the ret value was not propagated to the callers. Fix the error path. > > Reported-by: Krzysztof Kozlowski <[email protected]> > Signed-off-by: Javier Martinez Canillas <[email protected]> > Reviewed-by: Krzysztof Kozlowski <[email protected]> > Tested-by: Krzysztof Kozlowski <[email protected]> > Acked-by: Laxman Dewangan <[email protected]>
Reviewed-by: Andi Shyti <[email protected]> > --- > > Changes in v3: > - Add Krzysztof Kozlowski's Reviewed-by and Tested-by to patch #1. > - Add Laxman Dewangan's Acked-by tag to patch #1. > > Changes in v2: None > > drivers/rtc/rtc-max77686.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c > index 7184a0eda793..6653c3d11b66 100644 > --- a/drivers/rtc/rtc-max77686.c > +++ b/drivers/rtc/rtc-max77686.c > @@ -235,7 +235,7 @@ static int max77686_rtc_read_alarm(struct device *dev, > struct rtc_wkalrm *alrm) > > out: > mutex_unlock(&info->lock); > - return 0; > + return ret; > } > > static int max77686_rtc_stop_alarm(struct max77686_rtc_info *info) > -- > 2.5.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" > in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html
