3.19.8-ckt14 -stable review patch.  If anyone has any objections, please let me 
know.

---8<------------------------------------------------------------

From: Herbert Xu <herb...@gondor.apana.org.au>

commit 4f0414e54e4d1893c6f08260693f8ef84c929293 upstream.

We need to load the TX SG list in sendmsg(2) after waiting for
incoming data, not before.

Reported-by: Dmitry Vyukov <dvyu...@google.com>
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
Tested-by: Dmitry Vyukov <dvyu...@google.com>
[ kamal: backport to 3.19-stable: context ]
Signed-off-by: Kamal Mostafa <ka...@canonical.com>
---
 crypto/algif_skcipher.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/crypto/algif_skcipher.c b/crypto/algif_skcipher.c
index c12207c..2931d8e 100644
--- a/crypto/algif_skcipher.c
+++ b/crypto/algif_skcipher.c
@@ -439,13 +439,6 @@ static int skcipher_recvmsg(struct kiocb *unused, struct 
socket *sock,
                char __user *from = iov->iov_base;
 
                while (seglen) {
-                       sgl = list_first_entry(&ctx->tsgl,
-                                              struct skcipher_sg_list, list);
-                       sg = sgl->sg;
-
-                       while (!sg->length)
-                               sg++;
-
                        if (!ctx->used) {
                                err = skcipher_wait_for_data(sk, flags);
                                if (err)
@@ -466,6 +459,13 @@ static int skcipher_recvmsg(struct kiocb *unused, struct 
socket *sock,
                        if (!used)
                                goto free;
 
+                       sgl = list_first_entry(&ctx->tsgl,
+                                              struct skcipher_sg_list, list);
+                       sg = sgl->sg;
+
+                       while (!sg->length)
+                               sg++;
+
                        ablkcipher_request_set_crypt(&ctx->req, sg,
                                                     ctx->rsgl.sg, used,
                                                     ctx->iv);
-- 
1.9.1

Reply via email to