On 03.02.2016 18:30, Laxman Dewangan wrote: > There is different RTC I2C address for RTC block in MAX77686. > Driver is creating dummy i2c client for this address to access > the register of this IP block. > > As there is no need to get any data from this rtc i2c client, > it is not required to set client data for this i2c client. > > Suggested-by: Krzysztof Kozlowski <k.kozlow...@samsung.com> > Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> > CC: Krzysztof Kozlowski <k.kozlow...@samsung.com> > CC: Javier Martinez Canillas <jav...@osg.samsung.com> > > --- > This is new in this series based on review comment from V1. >
You could trim a little bit the description - "stored pointer is not retrieved anywhere, there is no call to i2c_get_clientdata()" might be sufficient but anyway: Reviewed-by: Krzysztof Kozlowski <k.kozlow...@samsung.com> Best regards, Krzysztof