> From: [email protected] [[email protected]] on behalf > of Jon Maxwell [[email protected]] > Sent: Sunday, January 24, 2016 3:22 PM > To: Kirsher, Jeffrey T > Cc: [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; Jon Maxwell > Subject: [net] igbvf: remove "link is Up" message when registering mcast > address > > A similar issue was addressed a few years ago in the following thread: > > http://www.spinics.net/lists/netdev/msg245877.html > > At that time there were concerns that removing this statement may cause other > side effects. However the submitter addressed those concerns. But the dialogue > went cold. We have a new case where a customers application is registering and > un-registering multicast addresses every few seconds. This is leading to many > "Link is Up" messages in the logs as a result of the > "netif_carrier_off(netdev)" statement called by igbvf_msix_other(). Also on > some kernels it is interfering with the bonding driver causing it to failover > and subsequently affecting connectivity. > > The Sourgeforge driver does not make this call and is therefore not affected. > If there were any side effects I would expect that driver to also be affected. > I have tested re-loading the igbvf driver and downing the adapter with the PF > entity on the host where the VM has this patch. When I bring it back up again > connectivity is restored as expected. Therefore I request that this patch gets > submitted. > > Signed-off-by: Jon Maxwell <[email protected]> > --- > drivers/net/ethernet/intel/igbvf/netdev.c | 1 - > 1 file changed, 1 deletion(-) >
Tested-by: Aaron Brown <[email protected]>
