On 10 February 2016 at 17:49, Lee Jones <[email protected]> wrote: > On Fri, 05 Feb 2016, Tomeu Vizoso wrote: > >> From: Sameer Nanda <[email protected]> >> >> This driver exposes the charger functionality in the PD EC to userspace. >> >> Signed-off-by: Tomeu Vizoso <[email protected]> >> Cc: Sameer Nanda <[email protected]> >> Cc: Benson Leung <[email protected]> >> Cc: Shawn Nematbakhsh <[email protected]> >> --- >> >> drivers/platform/chrome/cros_ec_proto.c | 37 ++ >> drivers/power/Kconfig | 10 + >> drivers/power/Makefile | 1 + >> drivers/power/cros_usbpd-charger.c | 907 >> ++++++++++++++++++++++++++++++++ >> include/linux/mfd/cros_ec.h | 28 + >> include/linux/mfd/cros_ec_commands.h | 324 +++++++++++- >> 6 files changed, 1302 insertions(+), 5 deletions(-) >> create mode 100644 drivers/power/cros_usbpd-charger.c > > A 1300 line patch crossing 3 subsystems is not the way you should be > submitting code. Please split these up into separate commits. The > only time you should squash all this functionality into a single patch > is to mitigate otherwise unavoidable build issues. I do not believe > that's the case here.
Agreed, sorry about that. Thanks, Tomeu
