On Wed, 17 Feb 2016, Julia Lawall wrote:
> > > On Wed, 17 Feb 2016, One Thousand Gnomes wrote: > > > On Wed, 17 Feb 2016 22:53:29 +0530 > > Amitoj Kaur Chawla <[email protected]> wrote: > > > > > This change has been made with the goal that kernel functions should > > > return something more descriptive than -1 on failure. > > > > > > Change the return value on valid_batchbuffer_addr() failure from -1 > > > to -EINVAL. > > > > > > Signed-off-by: Amitoj Kaur Chawla <[email protected]> > > > > NAK. It's not user visible, it's a piece of code that has a pile of other > > more important fixes needed first, and it's also as far as possible kept > > aligned with the Android upstream. > > > > If it were some random otherwise unchanging bit of code then it might > > just about make sense but in this case no - especially when you only > > change one of the two returns of -1 ! > > The other has been chahged already in a patch in the staging tree. Maybe > it's not in linux-next yet? It's there too: 1d427da1d7f9f81c4f5439c9610683d3cb9c1921 julia
