On Fri, Feb 19, 2016 at 02:15:46PM +0000, Marc Zyngier wrote: > On 19/02/16 13:34, Thomas Petazzoni wrote: > > This commits adds a new irqchip driver that handles the ODMI > > controller found on Marvell 7K/8K processors. The ODMI controller > > provide MSI interrupt functionality to on-board peripherals, much like > > the GIC-v2m. > > > > Signed-off-by: Thomas Petazzoni <[email protected]> > > --- > > Changes v2 -> v2: > > - Express NODMIS_SHIFT, NODMIS_PER_FRAME, NODMIS_MASK in term of each > > other. Suggested by Marc Zyngier. > > - Rework the global bitmask allocation to make sure we allocate a > > number of longs rather than a number of bytes, to avoid having the > > bitmap API (which operates on longs) access memory we haven't > > explicitly allocated. Reported by Marc Zyngier. > > > > Changes v1 -> v2: > > - Better commit title, as suggested by Marc Zyngier. > > - Improve the DT binding documentation, as suggested by Marc Zingier: > > add a reference to the GIC documentation, be more specific about > > the marvell,spi-base values, and add the requirement of the > > interrupt-parent property. > > - As suggested by Marc Zyngier, use a single global bitmap to > > allocate all ODMIs, regardless of the frame they belong to. As part > > of this change, the hwirq used to identify the interrupt inside the > > ODMI irqdomain are 0-based (instead of being based on their > > corresponding SPI base value), which allows to significantly > > simplify the allocation/free logic. > > --- > > .../marvell,odmi-controller.txt | 41 ++++ > > drivers/irqchip/Kconfig | 4 + > > drivers/irqchip/Makefile | 1 + > > drivers/irqchip/irq-mvebu-odmi.c | 248 > > +++++++++++++++++++++ > > 4 files changed, 294 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/interrupt-controller/marvell,odmi-controller.txt > > create mode 100644 drivers/irqchip/irq-mvebu-odmi.c > > Reviewed-by: Marc Zyngier <[email protected]> > > I'll queue that for 4.6.
I had it on my list to queue up, but you beat me to it. :-) thx, Jason.
