On 2016/2/19 21:53, Arnaldo Carvalho de Melo wrote:
Sorry for the top post, but the message below didn't made it thru due to
local problems as I recently switched notebooks, my postfix setup barfed
this one :-\
This is what I have in my tmp.perf/bpf_map:
https://git.kernel.org/cgit/linux/kernel/git/acme/linux.git/commit/?h=tmp.perf/bpf_map&id=5c78fe3c5a944ba7f9a85f59548295211f3d252c
Please take a look and see if you're ok with it,
I agree your change, but the commit you mentioned has a bug
which I have already fixed in Feb. 19 patch set:
At bpf_map__config_value:
+ if (!term->type_val == PARSE_EVENTS__TERM_TYPE_NUM) {
+ pr_debug("ERROR: wrong value type\n");
+ return -BPF_LOADER_ERRNO__OBJCONF_MAP_VALUE;
+ }
Should use
if (term->type_val != PARSE_EVENTS__TERM_TYPE_NUM)
I'll switch 'maps' to 'map' as you did in my tree and send this
patch again. (still based on perf/core, so I can solve potential
conflicts in my side).
Thank you.
