On Thu, Feb 18, 2016 at 05:32:48PM +0000, Will Deacon wrote: > On Thu, Feb 18, 2016 at 05:50:12PM +0100, Jan Glauber wrote: > > Add a compatible string for the Cavium ThunderX PMU. > > Stupid question, but is "thunder" the name of the CPU or the SoC or ...? > > Whatever we use to describe the PMU, should probably also identify the > CPU uniquely.
The CPU is currently: compatible = "cavium,thunder", "arm,armv8"; We clearly need better names in case of a subsequent CPU, but for now I think we should stick to the existing name. Jan > Will > > > Signed-off-by: Jan Glauber <[email protected]> > > --- > > Documentation/devicetree/bindings/arm/pmu.txt | 1 + > > arch/arm64/boot/dts/cavium/thunder-88xx.dtsi | 5 +++++ > > 2 files changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/pmu.txt > > b/Documentation/devicetree/bindings/arm/pmu.txt > > index 5651883..d3999a1 100644 > > --- a/Documentation/devicetree/bindings/arm/pmu.txt > > +++ b/Documentation/devicetree/bindings/arm/pmu.txt > > @@ -25,6 +25,7 @@ Required properties: > > "qcom,scorpion-pmu" > > "qcom,scorpion-mp-pmu" > > "qcom,krait-pmu" > > + "cavium,thunder-pmu" > > - interrupts : 1 combined interrupt or 1 per core. If the interrupt is a > > per-cpu > > interrupt (PPI) then 1 interrupt should be specified. > > > > diff --git a/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi > > b/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi > > index 9cb7cf9..2eb9b22 100644 > > --- a/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi > > +++ b/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi > > @@ -360,6 +360,11 @@ > > <1 10 0xff01>; > > }; > > > > + pmu { > > + compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; > > + interrupts = <1 7 4>; > > + }; > > + > > soc { > > compatible = "simple-bus"; > > #address-cells = <2>; > > -- > > 1.9.1 > >
