Hi Sudip,
On 02/23/2016 12:30 AM, Sudip Mukherjee wrote:
> While building with W=1 we were getting build warning:
> drivers/tty/tty_audit.c:149:16: warning: variable 'sessionid' set but not used
>
> The local variable sessionid was only assigned the value of
> current->sessionid but was never reused.
Thanks for catching this.
While reviewing this patch, I noticed entire if clause can be reduced to
if (audit_enabled)
tty_audit_log("ioctl=TIOCSTI", dev, &ch, 1);
since auid is unused variable as well.
Regards,
Peter Hurley
> Signed-off-by: Sudip Mukherjee <[email protected]>
> ---
> drivers/tty/tty_audit.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/tty/tty_audit.c b/drivers/tty/tty_audit.c
> index 66d53fc..81fe3fb 100644
> --- a/drivers/tty/tty_audit.c
> +++ b/drivers/tty/tty_audit.c
> @@ -146,10 +146,8 @@ void tty_audit_tiocsti(struct tty_struct *tty, char ch)
>
> if (audit_enabled) {
> kuid_t auid;
> - unsigned int sessionid;
>
> auid = audit_get_loginuid(current);
> - sessionid = audit_get_sessionid(current);
> tty_audit_log("ioctl=TIOCSTI", dev, &ch, 1);
> }
> }
>
