On Mon, Feb 22, 2016 at 09:10:45AM +0000, Wang Nan wrote: > is_pos only useful for tracking events (fork, mmap, exit, ...). > Perf collects those events through evsel with 'tracking' set. > Therefore, there's no need to validate every is_pos against > evlist->is_pos. > > This patch is required after perf support PERF_SAMPLE_TAILSIZE. > Since there an extra u64 at the end of this type of evsels, is_pos > for evsel with PERF_SAMPLE_TAILSIZE setting is different from other > evsels. > > Signed-off-by: Wang Nan <[email protected]> > Signed-off-by: He Kuang <[email protected]> > Cc: Arnaldo Carvalho de Melo <[email protected]> > Cc: Jiri Olsa <[email protected]> > Cc: Masami Hiramatsu <[email protected]> > Cc: Namhyung Kim <[email protected]> > Cc: Zefan Li <[email protected]> > Cc: [email protected] > --- > tools/perf/util/evlist.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c > index c42e196..fef465a 100644 > --- a/tools/perf/util/evlist.c > +++ b/tools/perf/util/evlist.c > @@ -1274,8 +1274,15 @@ bool perf_evlist__valid_sample_type(struct perf_evlist > *evlist) > return false; > > evlist__for_each(evlist, pos) { > - if (pos->id_pos != evlist->id_pos || > - pos->is_pos != evlist->is_pos) > + if (pos->id_pos != evlist->id_pos) > + return false; > + /* > + * Only tracking events needs is_pos. Those events are > + * collected if evsel->tracking is selected. > + * For other evsel, is_pos is useless for other evsels,
typo in comment above ^^^ using twice 'other evsel' > + * so skip validating them. > + */ > + if (pos->tracking && pos->is_pos != evlist->is_pos) > return false; > } > > -- > 1.8.3.4 >
