Re: [PATCHv2 1/4] slub: Drop lock at the end of free_debug_processing

[Laura Abbott]

On 02/24/2016 06:22 AM, Paolo Bonzini wrote:

On 15/02/2016 19:44, Laura Abbott wrote:

-static inline struct kmem_cache_node *free_debug_processing(
+static inline int free_debug_processing(
        struct kmem_cache *s, struct page *page,
        void *head, void *tail, int bulk_cnt,
        unsigned long addr, unsigned long *flags) { return NULL; }

I think this has a leftover flags argument.

Paolo

Yes, I believe Andrew folded in a patch to the mm tree.

Thanks,
Laura

@@ -2648,8 +2646,7 @@ static void __slab_free(struct kmem_cache *s, struct page 
*page,
        stat(s, FREE_SLOWPATH);

        if (kmem_cache_debug(s) &&
-           !(n = free_debug_processing(s, page, head, tail, cnt,
-                                       addr, &flags)))
+           !free_debug_processing(s, page, head, tail, cnt, addr))