On Wed, Feb 24, 2016 at 08:29:32PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Feb 25, 2016 at 12:13:32AM +0900, Namhyung Kim escreveu: > > Hello, > > > > This patchset implements a new feature that collects hist entries in a > > hierachical manner. That means lower-level entries belong to an > > upper-level entry. The entry hierachy is built on the sort keys > > given, so users can set it whatever they want. It only shows > > top-level entries first, and user can expand/collapse it dynamically. > > > > * Changes from v6) > > - pass srcline, srcfile and trace_output of hist entry properly (Jiri) > > - use hist_entry__snprintf_alignment() (Jiri) > > Suggestion for further improvement: > > perf top --hierarchy -e sched:sched_switch -s > prev_comm,prev_pid,next_comm,next_pid > > Will have four levels, would be nice to have just two, perhaps expressed > via: > > perf top --hierarchy -e sched:sched_switch -s > prev_comm+prev_pid,next_comm+next_pid > > Where '+' would work as sort order separator, just like ',' but would > have special meaning for --hierarchy. > > What do you think?
Looks like a good addition. To do that, a hist entry has to have its own perf_hpp_list instead of a single perf_hpp_fmt. I'll try to implement it.. Thanks, Namhyung
