Hi Stephen, On Thu, Feb 25, 2016 at 9:26 PM, Stephen Boyd <[email protected]> wrote: > We forgot to free this clock when we return early in this code. > > Cc: Geert Uytterhoeven <[email protected]> > Signed-off-by: Stephen Boyd <[email protected]>
Acked-by: Geert Uytterhoeven <[email protected]> > --- > drivers/clk/shmobile/renesas-cpg-mssr.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/shmobile/renesas-cpg-mssr.c > b/drivers/clk/shmobile/renesas-cpg-mssr.c > index 925b6007e531..58e24b326a48 100644 > --- a/drivers/clk/shmobile/renesas-cpg-mssr.c > +++ b/drivers/clk/shmobile/renesas-cpg-mssr.c > @@ -348,6 +348,7 @@ static void __init cpg_mssr_register_mod_clk(const struct > mssr_mod_clk *mod, > #else > dev_dbg(dev, "Ignoring MSTP %s to prevent > disabling\n", > mod->name); > + kfree(clock); > return; > #endif I had hoped for the whole "#else /* !CLK_ENABLE_HAND_OFF */" branch to be removed before anyone would start to fix silly issues like this ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
