On 2/28/16 00:53, Theodore Ts'o wrote: > On Sat, Feb 27, 2016 at 10:32:04PM +0800, Chen Gang wrote: >> I don't think so. Of cause NOT the "CODE CHURN". It is not correct to >> make an early decision during discussing. > > There is no discussion. If the maintainer has NAK'ed it. That's the > end of the dicsussion. Period. See: >
For me, NAK also needs reasons. And this issue is about "coding styles issue", I am not quite sure whether trivial patch maintainer and mm maintainer are also the maintainer for "coding styles issues". I guess they are related with this patch, and their NAKs' reason are: mm and trivial don't care about this coding style issue, is it correct? > ftp://ftp.kernel.org/pub/linux/kernel/people/rusty/trivial/template-index.html > > Also note the comment from the above: > > NOTE: This means I'll only take whitespace/indentation fixes from the > author or maintainer. OK, thanks, it is really one proof for us. :-) I guess, the file above almost means: except whitespace/indentation, trivial patches don't consider about the coding styles issues. But can we say coding styles issues are not issues in our kernel? (I guess not) If we can not say, I guess one of your suggestion is useful (maybe be as your suggestion): find one suitable member (I guess I am not), run "checkpatch -file" under "./include", and fix all reported issues. Thanks. -- Chen Gang (陈刚) Managing Natural Environments is the Duty of Human Beings.
