On Sat, Feb 27, 2016 at 03:16:03PM -0800, Luis R. Rodriguez wrote: > When we now use the new kernel_read_file_from_path() we > are reporting a failure when we iterate over all the paths > possible for firmware. Before using kernel_read_file_from_path() > we only reported a failure once we confirmed a file existed > with filp_open() but failed with fw_read_file_contents(). > > With kernel_read_file_from_path() both are done for us and > we obviously are now reporting too much information given that > some optional paths will always fail and clutter the logs. > > fw_get_filesystem_firmware() already has a check for failure > and uses an internal flag, FW_OPT_NO_WARN, to let users > warn or not warn. For instance request_firmware_direct() > does not warn as this can be used for optional firmware > as it has no usermode helper fallback. In the future we > may want to change this, given everyone is disabling the > usermode helper anyway now, but for now keep reporting > only as was designed. request_firmware_direct() will > continue to not report errors as it was designed not to. > > Reported-by: Heiner Kallweit <[email protected]> > Cc: Heiner Kallweit <[email protected]> > Cc: Mimi Zohar <[email protected]> > Cc: Kees Cook <[email protected]> > Signed-off-by: Luis R. Rodriguez <[email protected]> > --- > > Note, this is a fix for a small issue reported by Heiner after > Mimi's common kernel file loader changes were merged on James tree. > I'm following up through James. If this should go through someone > else's tree feel free to coordiante accordingly.
I'll be replacing this shortly with a v2. Luis
