On Thu, Jan 04, 2007 at 12:13:10PM -0600, Serge E. Hallyn wrote:
> From: Serge E. Hallyn <[EMAIL PROTECTED]>
> Subject: [PATCH -mm 8/8] user ns: implement user ns unshare
>
> Implement CLONE_NEWUSER flag useable at clone/unshare.
>
> Signed-off-by: Serge E. Hallyn <[EMAIL PROTECTED]>
> ---
> int copy_user_ns(int flags, struct task_struct *tsk)
> {
> - struct user_namespace *old_ns = tsk->nsproxy->user_ns;
> + struct user_namespace *new_ns, *old_ns = tsk->nsproxy->user_ns;
> int err = 0;
^^^^^^^^^^^^
The "= 0" is superfluous here.
>
> if (!old_ns)
> return 0;
>
> get_user_ns(old_ns);
> - return err;
> + if (!(flags & CLONE_NEWUSER))
> + return 0;
> + err = -EPERM;
> + if (!capable(CAP_SYS_ADMIN))
> + goto out;
> + err = -ENOMEM;
> + new_ns = clone_user_ns(old_ns);
> + if (!new_ns)
> + goto out;
> +
> + tsk->nsproxy->user_ns = new_ns;
> + err = 0;
> +out:
> + put_user_ns(old_ns);
> + return 0;
^^^^^^^^^
Should be "return err;"
Regards,
Frederik
> }
>
> void free_user_ns(struct kref *kref)
> --
> 1.4.1
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [EMAIL PROTECTED]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
