of_platform_device_create() returns NULL on error, it never returns
error pointers.

Fixes: 0df4fabe208d ('iommu/mediatek: Add mt8173 IOMMU driver')
Signed-off-by: Dan Carpenter <[email protected]>

diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
index 1a4022c..4682da4 100644
--- a/drivers/iommu/mtk_iommu.c
+++ b/drivers/iommu/mtk_iommu.c
@@ -628,7 +628,7 @@ static int mtk_iommu_probe(struct platform_device *pdev)
                        plarbdev = of_platform_device_create(
                                                larbnode, NULL,
                                                platform_bus_type.dev_root);
-                       if (IS_ERR(plarbdev))
+                       if (!plarbdev)
                                return -EPROBE_DEFER;
                }
                data->smi_imu.larb_imu[i].dev = &plarbdev->dev;
@@ -721,8 +721,8 @@ static int mtk_iommu_init_fn(struct device_node *np)
        struct platform_device *pdev;
 
        pdev = of_platform_device_create(np, NULL, platform_bus_type.dev_root);
-       if (IS_ERR(pdev))
-               return PTR_ERR(pdev);
+       if (!pdev)
+               return -ENOMEM;
 
        ret = platform_driver_register(&mtk_iommu_driver);
        if (ret) {

Reply via email to