Re: [PATCH 3/6] x86/mbm: Intel Memory B/W Monitoring enumeration and init

[Vikas Shivappa]

On Wed, 2 Mar 2016, Thomas Gleixner wrote:

On Tue, 1 Mar 2016, Vikas Shivappa wrote:
@@ -1397,8 +1543,11 @@ static int __init intel_cqm_init(void)
        __perf_cpu_notifier(intel_cqm_cpu_notifier);
 out:
        cpu_notifier_register_done();
-       if (ret)
+       if (ret) {
+               mbm_enabled = false;
+               cqm_enabled = false;
                kfree(str);


Leaks mbm_local and mbm_total ....

Will fix. Thanks for pointing out. I missed the ones which are done at the 
next level of calls from the init. Will do a check on all the globals as well.

Vikas


+       }

        return ret;
 }
--
1.9.1