2016-03-03 18:01 GMT+09:00 Geert Uytterhoeven <[email protected]>: > > Hi Krzysztof, > > On Thu, Mar 3, 2016 at 9:44 AM, Krzysztof Kozlowski > <[email protected]> wrote: > > --- a/drivers/thermal/Kconfig > > +++ b/drivers/thermal/Kconfig > > @@ -177,7 +177,7 @@ config THERMAL_EMULATION > > > > config HISI_THERMAL > > tristate "Hisilicon thermal driver" > > - depends on (ARCH_HISI && CPU_THERMAL && OF) || COMPILE_TEST > > + depends on (ARCH_HISI && CPU_THERMAL && OF) || COMPILE_TEST && > > HAS_IOMEM > > I think these are easier to read and maintain if you split hard and soft > dependencies, e.g. > > depends on HAS_IOMEM > depends on (ARCH_HISI && CPU_THERMAL && OF) || COMPILE_TEST
Indeed this looks more readable but the HAS_IOMEM becomes a missing dependency only for COMPILE_TEST. Usually it is included in the architecture. None of the approaches look perfect to me... Thanks for feedback! Best regards, Krzysztof
