-----Original Message-----
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
Sent: Monday, January 08, 2007 1:31 PM
To: Lu, Yinghai
Cc: Linus Torvalds; Tobias Diedrich; Andrew Morton; Adrian Bunk; Andi
Kleen; Linux Kernel Mailing List
Subject: Re: [PATCH 1/4] x86_64 io_apic: Implement remove_pin_to_irq
>Any updates to add_pin_to_irq are wrong. It works fine. If there
>is something wrong we need to fix remove_pin_to_irq.
>What is the problem you see? Sorry I'm dense at the moment.
+static int check_timer_pin(int apic, int pin) {
+ int irq, idx;
+ /*
+ * Test the architecture default i8254 timer pin
+ * of apic 0 pin 2.
+ */
+
+
+ /* If the apic pin pair is in use by another irq fail */
+ irq = irq_from_pin(apic, pin);
+ if ((irq != -1) && (irq != 0)) {
+ apic_printk(APIC_VERBOSE,KERN_INFO "...apic %d pin % in
use by irq %d\n",
+ apic, pin, irq);
+ return 0;
+ }
+
+ /* Add an entry in mp_irqs for irq 0 */
+ idx = update_irq0_entry(apic, pin);
+
+ /* Add an entry in irq_to_pin */
+ add_pin_to_irq(0, apic, pin);
+
+ /* Now setup the irq */
+ setup_IO_APIC_irq(apic, pin, idx, 0);
+
+ /* And finally check to see if the irq works */
+ return do_check_timer_pin(apic, pin);
+}
+
In the check_timer_pin, irq_from_pin could return 0, it mean some entry
is for IRQ0 already.
The add_pin_to_irq could add another same entry for it again.
YH
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
