Hi Lee,

On Tue, 12 Jan 2016, Lee Jones wrote:

> Doing so saves quite a bit of code in the driver.
> 
> For more information on the 'reserved-memory' bindings see:
> 
>   Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt
> 
> Suggested-by: Suman Anna <[email protected]>
> Signed-off-by: Lee Jones <[email protected]>
> ---
>  arch/arm/boot/dts/stih407-family.dtsi | 46 
> +++++++++++++++++++++++++++++------
>  1 file changed, 38 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/stih407-family.dtsi 
> b/arch/arm/boot/dts/stih407-family.dtsi
> index 15c20b6..27b8efc 100644
> --- a/arch/arm/boot/dts/stih407-family.dtsi
> +++ b/arch/arm/boot/dts/stih407-family.dtsi
> @@ -15,6 +15,36 @@
>       #address-cells = <1>;
>       #size-cells = <1>;
>  
> +     reserved-memory {
> +             #address-cells = <1>;
> +             #size-cells = <1>;
> +             ranges;
> +
> +             gp0_reserved: rproc@40000000 {
> +                     compatible = "shared-dma-pool";
> +                     reg = <0x40000000 0x01000000>;
> +                     no-map;
> +             };
> +
> +             gp1_reserved: rproc@41000000 {
> +                     compatible = "shared-dma-pool";
> +                     reg = <0x41000000 0x01000000>;
> +                     no-map;
> +             };
> +
> +             audio_reserved: rproc@42000000 {
> +                     compatible = "shared-dma-pool";
> +                     reg = <0x42000000 0x01000000>;
> +                     no-map;
> +             };
> +
> +             dmu_reserved: rproc@43000000 {
> +                     compatible = "shared-dma-pool";
> +                     reg = <0x43000000 0x01000000>;
> +                     no-map;
> +             };

I don't believe these reserved memory ranges are correct for audio_reserved and 
dmu_reserved.

For example my vid_firmware-stih407.elf is linked at 0x41c00000 base address 
and my
audio_firmware-bd-stih407.elf is linked at 0x40c00000.

So with all the st231 rproc nodes enabled I guess it would still work. But
currently I think st231_gp0 is reserving the memory region for st231_audio,
and st231-gp1 is reserving the memory region for st231_dmu.

regards,

Peter.

Reply via email to