On Fri, 25 Mar 2016 08:57:59 +0100 Richard Weinberger <rich...@nod.at> wrote:
> Am 25.03.2016 um 07:31 schrieb Yaowei Bai: > > On Fri, Mar 25, 2016 at 10:54:51AM +0800, Dongsheng Yang wrote: > >> ccing: Brian and Richard > >> > >> Hi Yao, > >> Is that really necessary? I am not sure how much benefit we can > >> achieve from this change. > >> Could you explain more? > > > > Yes, according to these functions' name, a boolean return value is more > > suitable and matchable. > > > > Also personally think this change maybe benfit function's return value > > storage in the stack when called on certain architectures. > > On which archs? And what exactly is the benefit? > I agree that bool might be a better choice for new functions > but here you're touching existing and working(!) code. > The only outcome is git history pollution that makes git blame > less efficient. Indeed, you raised a good point. Having useless changes pollute git blame output may be problematic. Not sure I want to apply those patches anymore :-/. Anyway, Yao, I'm sure you can find other usefull things to contribute. -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
