On Wed, Mar 30, 2016 at 3:23 AM, Rob Herring <r...@kernel.org> wrote: > Drivers shouldn't have to care about HAS_IOMEM to compile and having to > causes a Kconfig mess: > > warning: (MEDIA_SUBDRV_AUTOSELECT && VIDEO_CX231XX && INV_MPU6050_I2C) > selects I2C_MUX which has unmet direct dependencies (I2C && HAS_IOMEM) > warning: (ST_IRQCHIP && STMMAC_PLATFORM && DWMAC_IPQ806X && DWMAC_LPC18XX && > DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW && PINCTRL_ROCKCHIP > && PINCTRL_DOVE && POWER_RESET_KEYSTONE && S3C2410_WATCHDOG && VIDEO_OMAP3 && > VIDEO_S5P_FIMC && USB_XHCI_MTK && RTC_DRV_AT91SAM9 && LPC18XX_DMAMUX && > VIDEO_OMAP4 && HWSPINLOCK_QCOM && ATMEL_ST && QCOM_GSBI && PHY_HI6220_USB) > selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM) > > Reuse the !MMU variants for !HAS_IOMEM as they are sufficient for our > needs. This fixes build errors for UM allyesconfig: > > drivers/mfd/syscon.c:89:2: error: implicit declaration of function 'iounmap' > [-Werror=implicit-function-declaration] > iounmap(base); > > Reported-by: Fengguang Wu <fengguang...@intel.com> > Cc: Arnd Bergmann <a...@arndb.de> > Cc: linux-a...@vger.kernel.org > Signed-off-by: Rob Herring <r...@kernel.org> > --- > include/asm-generic/io.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Some time ago I posted patches adding the dependency, but that path looks like a better approach: Tested-by: Krzysztof Kozlowski <k.kozlow...@samsung.com> Best regards, Krzysztof
