On Tue, 12 Apr 2016 20:39:00 +0200, Paul Bolle wrote: > > On zo, 2016-04-10 at 11:35 -0700, Greg Kroah-Hartman wrote: > > --- a/sound/pci/hda/patch_hdmi.c > > +++ b/sound/pci/hda/patch_hdmi.c > > @@ -1670,11 +1670,10 @@ static void sync_eld_via_acomp(struct hd > > int size; > > > > mutex_lock(&per_pin->lock); > > + eld->monitor_present = false; > > size = snd_hdac_acomp_get_eld(&codec->bus->core, per_pin->pin_nid, > > &eld->monitor_present, eld->eld_buffer, > > ELD_MAX_SIZE); > > - if (size < 0) > > - goto unlock; > > This hunk triggers an obviously correct warning: > sound/pci/hda/patch_hdmi.c: In function 'sync_eld_via_acomp': > sound/pci/hda/patch_hdmi.c:1695:2: warning: label 'unlock' defined but > not used [-Wunused-label] > unlock: > ^ > > It's trivial to silence this warning for the v4.5 stable build, of > course. But I never saw this warning in my v4.6-rc builds, so it's > possible another patch should also be included in the v4.5 stable tree. > Takashi?
The newer kernel has more code jumping to unlock label, so it's a warning seen only on 4.5 kernel. If this really matters, we'd need a non-upstream fix to paper over it. thanks, Takashi
