On Wed, Apr 13, 2016 at 11:11:27AM -0600, Jason Gunthorpe wrote: > On Wed, Apr 13, 2016 at 10:22:06AM +0300, Jarkko Sakkinen wrote: > > rmmod crashes the driver because tpm_chip_unregister() already sets ops > > to NULL. This commit fixes the issue by moving tpm2_shutdown() to > > tpm_chip_unregister(). This commit is also cleanup because it removes > > duplicate code from tpm_crb and tpm_tis to the core. > > > > v2: make sending shutdown command atomic with nulling ops > > v3: forgot to amend updates, sorry :( > > Signed-off-by: Jarkko Sakkinen <[email protected]> > > Fixes: 4d3eac5e156a ("tpm: Provide strong locking for device > > removal") > > You patch got a little mangled.. The v2/v3 should be after the > diffstat, not in the commit message and the --- after the SOB section > is missing.. > > Otherwise it looks fine > > Reviewed-by: Jason Gunthorpe <[email protected]>
Thanks I'll apply this. /Jarkko > > extern int tpm2_startup(struct tpm_chip *chip, u16 startup_type); > > -extern void tpm2_shutdown(struct tpm_chip *chip, u16 shutdown_type); > > +void tpm2_shutdown(struct tpm_chip *chip, u16 shutdown_type); > > Drop this hunk though, doesn't do anything. > > If you don't like the unnecessary externs on functions then get rid of > them all in a patch. [x] > Jason /Jarkko
