2016-04-15 18:36 GMT+09:00 Ulf Hansson <[email protected]>: > On 15 April 2016 at 11:30, Masahiro Yamada > <[email protected]> wrote: >> 2016-04-15 18:26 GMT+09:00 Ulf Hansson <[email protected]>: >>> On 15 April 2016 at 11:01, Masahiro Yamada >>> <[email protected]> wrote: >>>> Hi Ulf, >>>> >>>> No interest in this clean-up? >>>> >>> >>> Well, no. >>> >>> Don't get me wrong, I am interested in clean-ups, but this doesn't >>> improve code quality that much. >>> >> >> At least, current code splits the error message string into two lines. >> >> > > Yes, and that minor improvement also makes it more cumbersome to use > "git blame" when trying to understand why something was changed. > > Hopes that clarifies how I think. It's balance. :-)
OK. This balance slightly varies from maintainer to maintainer. I am quite new to this sub-system, so I need to learn your criteria. I spent some time to read the MMC core code before starting to write my own MMC driver. During diving into the code, I left some tiny patches, which I think clean-ups(, but perhaps sound cumbersome for you). So, please give me your 1 minute to learn how your bar's height. For example, is the following above or below your bar? https://github.com/masahir0y/linux-yamada/commit/fe4e4bc06 If welcome, I am happy to post it, of course. but if not, please feel free to say so. Thanks. -- Best Regards Masahiro Yamada
