On 2016-04-18 17:33, Thierry Reding wrote: > On Sun, Apr 10, 2016 at 09:04:48PM -0700, Jan Kiszka wrote: >> On 2016-04-08 02:16, Thierry Reding wrote: >>> From: Thierry Reding <tred...@nvidia.com> >>> >>> Avoid forking off a shell to resolve the absolute path of the output >>> directory when make's builtin $(abspath ...) function will do an >>> adequate job. >>> >>> Signed-off-by: Thierry Reding <tred...@nvidia.com> >>> --- >>> scripts/gdb/linux/Makefile | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/scripts/gdb/linux/Makefile b/scripts/gdb/linux/Makefile >>> index 6cf1ecf61057..d8b88e22e16a 100644 >>> --- a/scripts/gdb/linux/Makefile >>> +++ b/scripts/gdb/linux/Makefile >>> @@ -1,6 +1,6 @@ >>> always := gdb-scripts >>> >>> -SRCTREE := $(shell cd $(srctree) && /bin/pwd) >>> +SRCTREE := $(abspath $(srctree)) >>> >>> $(obj)/gdb-scripts: >>> ifneq ($(KBUILD_SRC),) >>> >> >> Thanks, good cleanup. Queued. > > You might want to remove this, if it's not too late yet. I posted
Still in my queue only. > another similar thread and people objected to it because it requires > GNU make 3.81, whereas the kernel build process officially still > supports 3.80. Hmm, I scanned the kernel for this pattern before, and there were hits... ah, only in tools/, not in the main build. OK, will drop again. Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux
