On 04/18, Neil Armstrong wrote:
> +
> +static int oxnas_stdclk_probe(struct platform_device *pdev)
> +{
> + struct device_node *np = pdev->dev.of_node;
> + struct clk_oxnas_data *clk_oxnas;
> + struct regmap *regmap;
> + int i;
> +
> + clk_oxnas = devm_kzalloc(&pdev->dev, sizeof(*clk_oxnas), GFP_KERNEL);
> + if (!clk_oxnas)
> + return -ENOMEM;
> +
> + regmap = syscon_node_to_regmap(of_get_parent(np));
> + if (!regmap) {
> + dev_err(&pdev->dev, "failed to have parent regmap\n");
> + return -EINVAL;
> + }
> +
> + for (i = 0; i < ARRAY_SIZE(clk_oxnas_init); i++) {
> + struct clk_oxnas *_clk;
> +
> + if (!clk_oxnas_init[i].clk_init)
> + continue;
New design is fine, really it's up to you, but then this check
isn't needed anymore, right?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
