On Thu, 14 Apr 2016 17:16:40 +0800 Huang Shijie <shijie.hu...@arm.com> wrote:

> The patch "3033f14a clone: support passing tls argument via C rather ..."
> added the tls argument for _do_fork(). The patch adds the "tls" argument
> for j_do_fork to make it match  _do_fork().
> 
> ...
>
> --- a/samples/kprobes/jprobe_example.c
> +++ b/samples/kprobes/jprobe_example.c
> @@ -25,7 +25,7 @@
>  /* Proxy routine having the same arguments as actual _do_fork() routine */
>  static long j_do_fork(unsigned long clone_flags, unsigned long stack_start,
>             unsigned long stack_size, int __user *parent_tidptr,
> -           int __user *child_tidptr)
> +           int __user *child_tidptr, unsigned long tls)
>  {
>       pr_info("jprobe: clone_flags = 0x%lx, stack_start = 0x%lx "
>               "stack_size = 0x%lx\n", clone_flags, stack_start, stack_size);

The changelog failed to tell us what are the runtime effects of this
bug.  Please always include this info so that others can decide
which kernel version(s) need fixing.

Thanks.

Reply via email to