On Wed, Apr 27, 2016 at 05:35:31PM +0200, Hans de Goede wrote: > On 27-04-16 17:12, Mark Brown wrote:
> >Why not just implement that? > Given the formula in the datasheet to calculate the ldo_io > regulator voltage 0x1f maps to 3.8V, but according to the > datasheet the maximum voltage supported is 3.3V, iow the > power-on-reset value of this register is out of spec > according to the datasheet. Well, I guess someone can just measure what happens? > >We know what it does and it preserves the > >expected behaviour where we don't touch the regualtor unless explicitly > >told it's OK. We'll only ever try to set that value if the machine > >explicitly gives permission for it. > The problem is that if we do not fix the out of spec > register value then _regulator_get_voltage returns > -EINVAL because the register value exceeds n_voltages This will no longer be the case when the driver understands what the startup value means.
signature.asc
Description: PGP signature
