Re: [PATCH V2] pinctrl: tegra: Correctly check the supported configuration

[Stephen Warren]

On 05/02/2016 11:23 AM, Laxman Dewangan wrote:
The pincontrol registers of Tegra chips has multiple filed per
registers. There is two type of registers mux and drive. All
configurations belongs to one of these registers.
If any configurations are supported then <config>_bit is set to
bit position of these registers otherwise -1 to not support it.
The member is defined as
        s32 <config>_bit:6;

So if config is not supported ifor given SoC then it is set to -1
in soc pinmmux table.
In common driver code, to find out that given config is supported
or not, it is checked as:

s8 bit = <config>_bit;
if (bit > 31) {
        /* Not supported config */
}

But in this case, bit is s8 and hence for non supporting it is -1.

Correct the check as:
if (bit < 0) {
        /* Not supported config */
}

Fixes: e4c02dced975cb ("pinctrl: tegra: use signed bitfields for optional 
fields")

Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com>

Nit: There shouldn't be a blank line between the Fixes: and 
Signed-off-by: lines. I assume this can be fixed when the patch is applied.

Acked-by: Stephen Warren <swar...@nvidia.com>