Add a unit test that provides coverage for the bug fixed in the commit
entitled "radix-tree: rewrite radix_tree_locate_item fix" from Hugh
Dickins.  I've verified that this test fails before his patch due to
miscalculated 'index' values in __locate() in lib/radix-tree.c, and passes
with his fix.

Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com>
Cc: Hugh Dickins <hu...@google.com>
Cc: Andrew Morton <a...@linux-foundation.org>
---
 tools/testing/radix-tree/linux/init.h |  1 +
 tools/testing/radix-tree/main.c       | 15 ++++++++++++++-
 2 files changed, 15 insertions(+), 1 deletion(-)
 create mode 100644 tools/testing/radix-tree/linux/init.h

diff --git a/tools/testing/radix-tree/linux/init.h 
b/tools/testing/radix-tree/linux/init.h
new file mode 100644
index 0000000..360cabb
--- /dev/null
+++ b/tools/testing/radix-tree/linux/init.h
@@ -0,0 +1 @@
+/* An empty file stub that allows radix-tree.c to compile. */
diff --git a/tools/testing/radix-tree/main.c b/tools/testing/radix-tree/main.c
index 65231e9..b7619ff 100644
--- a/tools/testing/radix-tree/main.c
+++ b/tools/testing/radix-tree/main.c
@@ -232,7 +232,7 @@ void copy_tag_check(void)
        item_kill_tree(&tree);
 }
 
-void __locate_check(struct radix_tree_root *tree, unsigned long index,
+static void __locate_check(struct radix_tree_root *tree, unsigned long index,
                        unsigned order)
 {
        struct item *item;
@@ -248,12 +248,25 @@ void __locate_check(struct radix_tree_root *tree, 
unsigned long index,
        }
 }
 
+static void __order_0_locate_check(void)
+{
+       RADIX_TREE(tree, GFP_KERNEL);
+       int i;
+
+       for (i = 0; i < 50; i++)
+               __locate_check(&tree, rand() % INT_MAX, 0);
+
+       item_kill_tree(&tree);
+}
+
 static void locate_check(void)
 {
        RADIX_TREE(tree, GFP_KERNEL);
        unsigned order;
        unsigned long offset, index;
 
+       __order_0_locate_check();
+
        for (order = 0; order < 20; order++) {
                for (offset = 0; offset < (1 << (order + 3));
                     offset += (1UL << order)) {
-- 
2.5.5

Reply via email to