On 05/09/2016 04:50 PM, Yu-cheng Yu wrote: >> > >> > Oh, and if you decided to do this for some reason, please have mercy and >> > go make a macro for 1<<63. >> > >> > Also, I don't think the kernel ever checks for this bit. So are we >> > really calling XRSTORS on otherwise uninitialized xsave buffers? > Right now if we do fpstate_init(), without this patch, it will > trigger a warning from copy_kernel_to_fxregs() when the task is > scheduled.
Please include this in the patch description. It's a pretty important piece of justification. Did you mean "copy_kernel_to_xregs()" without the "f"? I think we should probably also have an _explicit_ FPU_WARN_ON() in the XRSTORS path for this. *Both* the booting and regular ones, btw...
