On May 10 2016 or thereabouts, Fabio Estevam wrote: > On Tue, May 10, 2016 at 12:37 PM, Benjamin Tissoires > <[email protected]> wrote: > > > @@ -92,7 +93,7 @@ soc_button_device_create(struct platform_device *pdev, > > continue; > > > > gpio = soc_button_lookup_gpio(&pdev->dev, info->acpi_index); > > - if (gpio < 0) > > + if (gpio_is_valid(gpio)) > > Shouldn't it be "if (!gpio_is_valid(gpio))" ?
Oops, indeed. I messed up between the various trees as it's not that convenient to recompile a full kernel on an atom device. Will fix this in v2. Cheers, Benjamin
