On 2016/5/13 21:15, Andy Shevchenko wrote: > On Fri, 2016-05-13 at 16:19 +0800, Yisen Zhuang wrote: >> From: Hanjun Guo <hanjun....@linaro.org> >> >> acpi_match_device_ids() will be used for drivers to match >> different hardware versions, it will be compiled in non-ACPI >> case, but acpi_match_device_ids() in acpi_bus.h and it can >> only be used in ACPI case, so move it to linux/acpi.h and >> introduce a stub function for it. > I somehow doubt this is right move. > > Like I said in the previous comment the architectural split might make > this a bit better. > > You might use > > #ifdef IS_ENABLED(CONFIG_ACPI) > #else > #endif > > only once to some big part of code. If kernel is build without ACPI > support you even will not have this in your driver at all.
Hi Andy, Thanks for your suggestions. It will add stub function instead in next submit. > -- > Andy Shevchenko <andriy.shevche...@linux.intel.com> > Intel Finland Oy > > > . >
