On Mon, 30 May 2016, Hans Ulli Kroll wrote:
> Missing event_handler in mfgpt_tick() caused a kernel panic.
So the real problem is that the interrupt in the device is enabled _BEFORE_
the clock event device is registered.
> diff --git a/drivers/clocksource/cs5535-clockevt.c
> b/drivers/clocksource/cs5535-clockevt.c
> index 9a7e37c..6f186cf 100644
> --- a/drivers/clocksource/cs5535-clockevt.c
> +++ b/drivers/clocksource/cs5535-clockevt.c
> @@ -129,7 +129,9 @@ static irqreturn_t mfgpt_tick(int irq, void *dev_id)
> cs5535_mfgpt_write(cs5535_event_clock, MFGPT_REG_SETUP,
> MFGPT_SETUP_CNTEN | MFGPT_SETUP_CMP2);
>
> - cs5535_clockevent.event_handler(&cs5535_clockevent);
> + if (cs5535_clockevent.event_handler)
> + cs5535_clockevent.event_handler(&cs5535_clockevent);
> +
So what about fixing the above problem instead of having a conditional in the
interrupt handler fast path?
Thanks,
tglx
