On 06/01/2016 09:03 AM, Thomas Gleixner wrote:
> On Tue, 31 May 2016, Neil Armstrong wrote:
>> +static int oxnas_rps_timer_shutdown(struct clock_event_device *evt)
>> +{
>> + struct oxnas_rps_timer *rps =
>> + container_of(evt, struct oxnas_rps_timer, clkevent);
>> +
>> + if (!clockevent_state_periodic(evt))
>> + return 0;
>
> So if the timer is in oneshot mode, then you just leave it enabled. What's the
> rationale of this?
Indeed, there is no rationale.
Fixed in v2.
>> +
>> + oxnas_rps_timer_config(rps, 0, 0);
>
> Thanks,
>
> tglx
>
Thanks,
Neil
