On 06/01/2016 12:16 PM, Rafał Miłecki wrote:
> Driver for Northstar USB 2.0 PHY was added in 4.7-rc1 by:
> commit d3feb4067335 ("phy: bcm-ns-usb2: new driver for USB 2.0 PHY on
> Northstar").
> It should be used to let EHCI platform driver init PHY.
> 
> Signed-off-by: Rafał Miłecki <[email protected]>
> ---
>  arch/arm/boot/dts/bcm5301x.dtsi | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi
> index 7d4d29b..9300e19 100644
> --- a/arch/arm/boot/dts/bcm5301x.dtsi
> +++ b/arch/arm/boot/dts/bcm5301x.dtsi
> @@ -140,6 +140,22 @@
>               };
>       };
>  
> +     phys {
> +             compatible = "simple-bus";
> +             ranges = <0x00000000 0x18000000 0x00100000>;
> +             #address-cells = <1>;
> +             #size-cells = <1>;
> +
> +             usb2_phy2: usb2-phy {
> +                     compatible = "brcm,ns-usb2-phy";
> +                     reg = <0x0000c000 0x1000>;
> +                     reg-names = "dmu";
> +                     #phy-cells = <0>;
> +                     clocks = <&genpll BCM_NSP_GENPLL_USB_PHY_REF_CLK>;
> +                     clock-names = "phy-ref-clk";
> +             };

You guys need to get everything straigthen up when it comes to busing
and child nodes for bcm53101x.dtsi, why do we need a "simple-bus" node
here which overlaps in part with the brcm-bus-axi node's range?

The more I look at BCMA and how it gets used for a non-external WLAN
card, and the less I am convinced it brings anything useful to the game,
quite the contrary...

> +     };
> +
>       axi@18000000 {
>               compatible = "brcm,bus-axi";
>               reg = <0x18000000 0x1000>;
> @@ -217,6 +233,8 @@
>  
>                       #address-cells = <1>;
>                       #size-cells = <1>;
> +
> +                     phys = <&usb2_phy2>;
>               };
>  
>               usb3: usb3@23000 {
> 


-- 
Florian

Reply via email to