For anyone new to the underlying goal of this cleanup, we are trying to
not use module support for code that can never be built as a module since:
(1) it is easy to accidentally write unused module_exit and remove code
(2) it can be misleading when reading the source, thinking it can be
modular when the Makefile and/or Kconfig prohibit it
(3) it requires the include of the module.h header file which in turn
includes nearly everything else, thus adding to CPP overhead.
(4) it gets copied/replicated into other code and spreads like weeds.
Similar to what was done for GPIO, I'd divided up the the audit of
modular usage in non-modular pinctrl drivers into reasonable batch
sizes to hopefully ease review.
This batch deals with individual standalone drivers that are nearly
all in the top level directory.
Changes seen here cover the following categories:
-just replacement of modular macros with their non-modular
equivalents that CPP would have inserted anyway
-the removal of including module.h ; replaced with init.h
as required based on whether the file already had it.
-the removal of any/all unused/orphaned __exit functions
that would never be called/exercised.
-the removal of any ".remove" functions that were hooked into
the driver struct. This ".remove" function would of
course not be called from the __exit function since that was
never run. However in theory, someone could have triggered it
via sysfs unbind, even though there isn't a sensible use case
for doing so. So to cover that possibility, we've also disabled
sysfs unbind in these drivers.
There are no initcall level changes here; everything was at the level
of device_initcall and remains so, by using the builtin equivalents.
Build tested for several different key arch on the Monday linux-next
tree to ensure no silly typos crept in.
Paul.
---
Cc: Baruch Siach <[email protected]>
Cc: Heikki Krogerus <[email protected]>
Cc: Jean-Christophe Plagniol-Villard <[email protected]>
Cc: Jeff Wu <[email protected]>
Cc: Joachim Eastwood <[email protected]>
Cc: Ken Xue <[email protected]>
Cc: Laxman Dewangan <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Ludovic Desroches <[email protected]>
Cc: Michal Simek <[email protected]>
Cc: Mika Westerberg <[email protected]>
Cc: "Sören Brinkmann" <[email protected]>
Cc: [email protected]
Paul Gortmaker (9):
pinctrl: as3722: make it explicitly non-modular
pinctrl: baytrail: make it explicitly non-modular
pinctrl: at91: make it explicitly non-modular
pinctrl: lpc18xx: make it explicitly non-modular
pinctrl: amd: make it explicitly non-modular
pinctrl: palmas: make it explicitly non-modular
pinctrl: zynq: make it explicitly non-modular
pinctrl: digicolor: make it explicitly non-modular
pinctrl: at91-pio4: make it explicitly non-modular
drivers/pinctrl/intel/pinctrl-baytrail.c | 25 ++++---------------------
drivers/pinctrl/pinctrl-amd.c | 23 +++--------------------
drivers/pinctrl/pinctrl-as3722.c | 20 +++-----------------
drivers/pinctrl/pinctrl-at91-pio4.c | 22 +++-------------------
drivers/pinctrl/pinctrl-at91.c | 11 -----------
drivers/pinctrl/pinctrl-digicolor.c | 16 +++-------------
drivers/pinctrl/pinctrl-lpc18xx.c | 20 +++-----------------
drivers/pinctrl/pinctrl-palmas.c | 10 ++--------
drivers/pinctrl/pinctrl-zynq.c | 13 +------------
9 files changed, 22 insertions(+), 138 deletions(-)
--
2.8.0
