At 2016-06-08 03:12:08, "James Bottomley" <james.bottom...@hansenpartnership.com> wrote: >On Wed, 2016-06-08 at 02:00 +0800, Tiezhu Yang wrote: >> There exists potential memory leak in ufshcd_parse_clock_info(), >> this patch fixes it. > >What makes you think there's a leak here? These are all devm_ >allocations, so they're all freed when the device is. If an error is >returned, the device is released and the memory freed. > >You can argue that on successful initialization, there's no need to >keep the clkfreq array but this patch isn't the way you'd change that. > >James > OK, thanks. I will send a v2 patch.