>> Documentation/coccinelle.txt suggests using the SPFLAGS >> make variable to pass additional options to spatch. >> >> Reorder the way SPFLAGS is added to FLAGS, to allow >> for options in the SPFLAGS to override the default >> --very-quiet option. >> >> Similarly, rearrage the FLAGS for org or report mode. >> This allows for overriding of the default --no-show-diff >> option through SPFLAGS. > > The first looks like a good idea, but do you find a use case for the > second? The diff that is shown in org or report mode may be sort of > random. It is just an easy hack to reuse the same pattern code for > context, org, and report modes, but there isn't an intent to see the diff > produced by context mode in org or report mode.
I thought this at first, that org report mode wouldn't need it the diff. But if a user wishes to override the option, then why should we not accept that the user knows what they are doing? -Deepa
