From: Jiri Kosina <[email protected]> Calculating size of the report as sizeof(pointer) always passess the length corresponding to the pointer type, not the underlying data report.
Reported-by: kbuild test robot <[email protected]> Signed-off-by: Jiri Kosina <[email protected]> --- drivers/hid/hid-alps.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c index 098bce6..ff64c929 100644 --- a/drivers/hid/hid-alps.c +++ b/drivers/hid/hid-alps.c @@ -136,7 +136,8 @@ static int u1_read_write_register(struct hid_device *hdev, u32 address, input[7] = check_sum; ret = hid_hw_raw_request(hdev, U1_FEATURE_REPORT_ID, input, - sizeof(input), HID_FEATURE_REPORT, HID_REQ_SET_REPORT); + sizeof(u8)*U1_FEATURE_REPORT_LEN, HID_FEATURE_REPORT, + HID_REQ_SET_REPORT); if (ret < 0) { dev_err(&hdev->dev, "failed to read command (%d)\n", ret); @@ -145,8 +146,8 @@ static int u1_read_write_register(struct hid_device *hdev, u32 address, if (read_flag) { ret = hid_hw_raw_request(hdev, U1_FEATURE_REPORT_ID, readbuf, - sizeof(readbuf), HID_FEATURE_REPORT, - HID_REQ_GET_REPORT); + sizeof(u8)*U1_FEATURE_REPORT_LEN, + HID_FEATURE_REPORT, HID_REQ_GET_REPORT); if (ret < 0) { dev_err(&hdev->dev, "failed read register (%d)\n", ret); -- Jiri Kosina SUSE Labs
