Hi Omar, Thanks for spotting, and submitting this.
On 20/06/16 21:00, Omar Sandoval wrote: > From: Omar Sandoval <osan...@fb.com> > > Since scripts/gdb/linux/constants.py is autogenerated, this should have > been added to .gitignore when it was introduced. Absolutely! - This never hit me, as I always build out-of-tree > Fixes: f197d75fcad1 ("scripts/gdb: provide linux constants") > Signed-off-by: Omar Sandoval <osan...@fb.com> Unfortunately - Nacked on the principle of the comment in the top of the .gitignore file: # NOTE! Don't add files that are generated in specific # subdirectories here. Add them in the ".gitignore" file # in that subdirectory instead. Could you fix this up (meaning add to the .gitignore under scripts/gdb/linux) and resend please? Then I'll add to my queue to send as fixes for current. (which I'm hoping to get sent before the weekend, or at the weekend) > --- > .gitignore | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/.gitignore b/.gitignore > index 0c320bf02586..5cdccb07e3a3 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -112,3 +112,6 @@ all.config > > # Kdevelop4 > *.kdev4 > + > +# Generated for CONFIG_GDB_SCRIPTS > +/scripts/gdb/linux/constants.py > -- Regards Kieran Bingham