On Thu, Jun 23, 2016 at 01:31:28PM -0700, John Stultz wrote: > On Wed, Jun 22, 2016 at 5:47 PM, Dmitry Torokhov > <[email protected]> wrote: > > On Tue, Jun 21, 2016 at 05:06:23PM -0700, John Stultz wrote: > >> On Tue, Jun 14, 2016 at 3:43 PM, John Stultz <[email protected]> > >> wrote: > >> > From: Jorge Ramirez-Ortiz <[email protected]> > >> > > >> > This driver provides a input driver for the power button on the > >> > HiSi 65xx SoC for boards like HiKey. > >> > > >> > This driver was originally by Zhiliang Xue <[email protected]> > >> > then basically rewritten by Jorge, but preserving the original > >> > module author credits. > >> > > >> > Cc: Dmitry Torokhov <[email protected]> > >> > Cc: Rob Herring <[email protected]> > >> > Cc: Lee Jones <[email protected]> > >> > Cc: Jorge Ramirez-Ortiz <[email protected]> > >> > Cc: Feng Chen <[email protected]> > >> > Cc: Wei Xu <[email protected]> > >> > Cc: Guodong Xu <[email protected]> > >> > Signed-off-by: Jorge Ramirez-Ortiz <[email protected]> > >> > [jstultz: Reworked commit message, folded in other fixes/cleanups > >> > from Jorge, implemented some larger cleanups suggested by DmitryT] > >> > Signed-off-by: John Stultz <[email protected]> > >> > --- > >> > v2: Major rework integrating feedback from Dmitry. > >> > v3: Dropped of_match compatible line since no longer using DT > >> > for this. > >> > v4: Removed MODULE_DEVICE_TABLE(of, hi65xx_powerkey_of_match) line > >> > I missed in the last revision, which casued build issues w/ > >> > modules. > >> > >> Hey Dmitry, > >> Just wanted to ping you to see if there was anything else you were > >> wanting changed with this patch. Lee has queued the mfd patches in > >> -next, so I wanted to be sure to address any concerns you had that was > >> keeping this from heading upstream in 4.8 (hopefully :). > > > > Right, sorry, does the following look OK to you? > > > > Yes! It looks great (and I tested it works too)! > > Do you want to fold that in, or do you need me to re-submit with those > changes?
I'll fold it in on my side. Thank you for testing it! -- Dmitry
