On Tuesday, June 28, 2016 10:29:27 AM Jisheng Zhang wrote: > Dear Rafael, > > On Mon, 27 Jun 2016 10:29:54 -0700 > Srinivas Pandruvada <[email protected]> wrote: > > > On Mon, 2016-06-27 at 18:07 +0800, Jisheng Zhang wrote: > > > pid_params is written once by copy_pid_params() during > > > initialization, > > > and thereafter is mostly read by hot path intel_pstate_update_util(). > > > The read of pid_params gets more after commit a4675fbc4a7a ("cpufreq: > > > intel_pstate: Replace timers with utilization update callbacks") > > > > > > pstate_funcs is written once by copy_cpu_funcs() during > > > initialization, > > > and thereafter is mostly read by hot path intel_pstate_update_util() > > > > > > hwp_active is written to once during initialization and thereafter is > > > mostly read by hot path intel_pstate_update_util(). > > > > > > The fact that they are mostly read and not written to makes them > > > candidates for __read_mostly declarations. > > > > > > Signed-off-by: Jisheng Zhang <[email protected]> > > Acked-by: Srinivas Pandruvada <[email protected]> > > oops, I missed Viresh's Ack in this patch, so can you please add the missing > > Acked-by: Viresh Kumar <[email protected]>
I've added it already. Thanks, Rafael
